Skip to content

Fixed #35 add ability to show latest added notification on top.#36

Open
lxzxl wants to merge 1 commit into
react-component:masterfrom
lxzxl:master
Open

Fixed #35 add ability to show latest added notification on top.#36
lxzxl wants to merge 1 commit into
react-component:masterfrom
lxzxl:master

Conversation

@lxzxl

@lxzxl lxzxl commented Jan 16, 2018

Copy link
Copy Markdown

No description provided.

@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 100.0% when pulling e01fdd6 on lxzxl:master into 8af073b on react-component:master.

@yesmeck yesmeck assigned yesmeck and unassigned yesmeck Jan 22, 2018
@yesmeck

yesmeck commented Jan 22, 2018

Copy link
Copy Markdown
Member

@valleykid

Comment thread README.md
<td>function returning html node which will act as notification container</td>
</tr>
<tr>
<td>isLastTop</td>

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need a better name.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isReverse ?

Or use isAddOnTop, mean is add a new notification to top or bottom and it not a global change yet.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

newestOnTop

@afc163

afc163 commented May 8, 2020

Copy link
Copy Markdown
Member

conflicted

@stephankaag

Copy link
Copy Markdown

@lxzxl Are you planning on fixing the conflicts?

@realhao

realhao commented May 18, 2022

Copy link
Copy Markdown

@lxzxl 这个新增功能是我们需要的,可以解决下冲突,完成 PR 吗?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants